[webkit-reviews] review granted: [Bug 47360] Web Inspector: all native breakpoints should inherit from NativeBreakpoint : [Attachment 70112] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 47360: Web Inspector: all native breakpoints should inherit from
NativeBreakpoint
https://bugs.webkit.org/show_bug.cgi?id=47360

Attachment 70112: Patch.
https://bugs.webkit.org/attachment.cgi?id=70112&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70112&action=review

> WebCore/inspector/InspectorDOMAgent.cpp:781
> +    pair<long, long> breakpoint = m_idToBreakpoint.take(breakpointId);

Could you typedef this in header so that we knew what is going on.

> WebCore/inspector/front-end/BreakpointManager.js:138
> +	   if (!(nodeId in this._domPathCache))

Please add // FIXME: