[webkit-reviews] review denied: [Bug 47413] [Qt] TestController needs it's platform dependent methods : [Attachment 70241] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 47413: [Qt] TestController needs it's platform dependent methods
https://bugs.webkit.org/show_bug.cgi?id=47413

Attachment 70241: Patch
https://bugs.webkit.org/attachment.cgi?id=70241&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70241&action=review

> WebKitTools/ChangeLog:5
> +	   [Qt] TestController needs it's platform dependent methods

s/it's/its/

> WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:90
> +    QString path = libPathFromEnv ? QLatin1String(libPathFromEnv)
> +				     : QCoreApplication::applicationDirPath() +
"/../lib/libWTRInjectedBundle.so";

This is platform-specific and needs to be cleaned up.