[webkit-reviews] review denied: [Bug 46775] getBoundingClientRect does not work with SVG <text> : [Attachment 70234] Fix and layout test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 8 06:41:30 PDT 2010
Nikolas Zimmermann <zimmermann at kde.org> has denied Cosmin Truta
<ctruta at chromium.org>'s request for review:
Bug 46775: getBoundingClientRect does not work with SVG <text>
https://bugs.webkit.org/show_bug.cgi?id=46775
Attachment 70234: Fix and layout test
https://bugs.webkit.org/attachment.cgi?id=70234&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70234&action=review
> WebCore/ChangeLog:9
> + through SVGElement::boundingBoxForElement.
Still says boundingBoxForElement here.
> WebCore/ChangeLog:27
> + (SVGElement::boundingBoxForElement): Added.
And here.
> WebCore/dom/Element.cpp:511
> + ASSERT(renderer());
The assertion is wrong, it would fire on <rect display="none"...>
More information about the webkit-reviews
mailing list