[webkit-reviews] review granted: [Bug 47275] Web Inspector: inspector settings/properties/states management should be extracted into separate class. : [Attachment 70213] [patch] third iteration.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 06:21:02 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 47275: Web Inspector: inspector settings/properties/states management
should be extracted into separate class.
https://bugs.webkit.org/show_bug.cgi?id=47275

Attachment 70213: [patch] third iteration.
https://bugs.webkit.org/attachment.cgi?id=70213&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70213&action=review

> WebCore/inspector/InspectorState.h:113
> +struct property_type_traits<String> {

Stick to style guide when naming the structs.

> WebCore/inspector/InspectorState.h:154
> +    void propertyUpdated(InspectorPropertyBase* property);

Should be private.


More information about the webkit-reviews mailing list