[webkit-reviews] review granted: [Bug 47409] SVG feImage needs absolute subregion for preserveAspectRatio : [Attachment 70228] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 47409: SVG feImage needs absolute subregion for preserveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=47409

Attachment 70228: Patch
https://bugs.webkit.org/attachment.cgi?id=70228&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70228&action=review

> WebCore/platform/graphics/filters/FilterEffect.h:46
> +enum FilterEffectType {
> +    unknownEffectType,
> +    feImage,
> +    feTile,
> +    sourceInput

This is ugly and doesn't conform to the style guide (style bot doesn't check
this).
"Enum members should user InterCaps with an initial capital letter." Also these
names are confusing.
FilterEffectTypeUnknown,
FilterEffectTypeImage,
FilterEffectTypeTile,
FilterEffectTypeSourceInput

The rest looks good. Except the name for the test directory, I'd prefer
LayoutTest/svg/W3C-SVG-1.1-SE/ (capital SE).
Please fix before landing.