[webkit-reviews] review granted: [Bug 47346] Web Inspector: add resource viewer to the network panel. : [Attachment 70081] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 47346: Web Inspector: add resource viewer to the network panel.
https://bugs.webkit.org/show_bug.cgi?id=47346

Attachment 70081: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=70081&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
Please make sure style checker is happy before landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=70081&action=review

> WebCore/inspector/front-end/DataGrid.js:924
> +	   var oldPercentLeftColumn =
parseFloat(this._headerTableColumnGroup.children[resizer.leftNeighboringColumnI
D].style.width);
> +	   var oldPercentRightColumn =
parseFloat(this._headerTableColumnGroup.children[resizer.rightNeighboringColumn
ID].style.width);

Please remove these two lines.

> WebCore/inspector/front-end/NetworkPanel.js:465
> +	   var timelineColumn = this._dataGrid.columns["timeline"];

this._dataGrid.columns["timeline"]; => this._dataGrid.columns.timeline;