[webkit-reviews] review granted: [Bug 45443] [GTK] Support for viewport meta tag : [Attachment 70074] Proposed Patch5

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Joone Hur
<joone at kldp.org>'s request for review:
Bug 45443: [GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

Attachment 70074: Proposed Patch5
https://bugs.webkit.org/attachment.cgi?id=70074&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70074&action=review

Looks good to me, but please pass the API through Gustavo or another GTK+
reviewer.

Also you need to change one call before this can be committed.

> WebKit/gtk/webkit/webkitviewportattributes.cpp:248
> +    WebCore::ViewportAttributes attrs =
WebCore::findConfigurationForViewportData(arguments, priv->desktopWidth,
priv->deviceWidth, 

The API recently changed to computeViewportAttribute.