[webkit-reviews] review denied: [Bug 46775] getBoundingClientRect does not work with SVG <text> : [Attachment 70200] Fix and augmented layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 01:48:42 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Cosmin Truta
<ctruta at chromium.org>'s request for review:
Bug 46775: getBoundingClientRect does not work with SVG <text>
https://bugs.webkit.org/show_bug.cgi?id=46775

Attachment 70200: Fix and augmented layout test
https://bugs.webkit.org/attachment.cgi?id=70200&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70200&action=review

> WebCore/svg/SVGElement.h:75
> +	   bool boundingBoxForElement(FloatRect&,
SVGLocatable::StyleUpdateStrategy = SVGLocatable::AllowStyleUpdate) const;

ok, you're right s/boundingBoxForElement/boundingBox/ is better.

You can't commit yet, right? r- then, waiting for your revised version.


More information about the webkit-reviews mailing list