[webkit-reviews] review requested: [Bug 46775] getBoundingClientRect does not work with SVG <text> : [Attachment 70200] Fix and augmented layout test

[bugzilla-daemon at webkit.org]

Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 46775: getBoundingClientRect does not work with SVG <text>
https://bugs.webkit.org/show_bug.cgi?id=46775

Attachment 70200: Fix and augmented layout test
https://bugs.webkit.org/attachment.cgi?id=70200&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
The fix is as suggested by Nico, except that I used boundingBoxForElement
instead of boundingBoxForSVGElement.
(Is this not a more appropriate name? I am a little confused here: it's either
boundingBoxForElement, to be used in Element; otherwise, should it not have
been simply SVGElement::boundingBox? The same naming style is used e.g. in
SVGElement::instancesForElement.)

The <text> fix also includes the zooming fix, previously submitted to 42815.

The layout test is focused on zooming, not on <text>, although it does include
a test for <text>, easy to identify on failure (unlike in the previous patch). 


There is still no JavaScript-driven zooming. I tried it, and it's flaky: it
works most of the time, but not all the time, and the remaining times the
coordinates are either off-by-one, or zero, or (rarely) contain garbage values.

Before adding such tests to zoom/page, I will look into how to make them
unflaky.