[webkit-reviews] review canceled: [Bug 47395] [EFL] Implement pageRect() function : [Attachment 70197] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 7 21:09:06 PDT 2010
Gyuyoung Kim <gyuyoung.kim at samsung.com> has canceled Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 47395: [EFL] Implement pageRect() function
https://bugs.webkit.org/show_bug.cgi?id=47395
Attachment 70197: Patch
https://bugs.webkit.org/attachment.cgi?id=70197&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
I understand that QT port is using frameRect() as well as this patch. So, I
also use the frameRect().
The frameRect() returns frameview size.
QSize QWebPage::viewportSize() const
{
if (d->mainFrame && d->mainFrame->d->frame->view())
return d->mainFrame->d->frame->view()->frameRect().size();
return d->viewportSize;
}
And, I add null checking code.
More information about the webkit-reviews
mailing list