[webkit-reviews] review granted: [Bug 47370] Make line boxes place themselves correctly in the inline direction. : [Attachment 70135] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 47370: Make line boxes place themselves correctly in the inline direction.
https://bugs.webkit.org/show_bug.cgi?id=47370

Attachment 70135: Patch
https://bugs.webkit.org/attachment.cgi?id=70135&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70135&action=review

Looks good other than the & issue.

> WebCore/rendering/style/RenderStyle.h:643
> +    void getTextShadowExtent(int &top, int &right, int &bottom, int &left)
const { getShadowExtent(textShadow(), top, right, bottom, left); }
> +    void getTextShadowHorizontalExtent(int &left, int &right) const {
getShadowHorizontalExtent(textShadow(), left, right); }
> +    void getTextShadowVerticalExtent(int &top, int &bottom) const {
getShadowVerticalExtent(textShadow(), top, bottom); }
> +    void getTextShadowInlineDirectionExtent(int &logicalLeft, int
&logicalRight) { getShadowInlineDirectionExtent(textShadow(), logicalLeft,
logicalRight); }

The & are on the wrong side.

> WebCore/rendering/style/RenderStyle.h:662
> +    void getBoxShadowExtent(int &top, int &right, int &bottom, int &left)
const { getShadowExtent(boxShadow(), top, right, bottom, left); }
> +    void getBoxShadowHorizontalExtent(int &left, int &right) const {
getShadowHorizontalExtent(boxShadow(), left, right); }
> +    void getBoxShadowVerticalExtent(int &top, int &bottom) const {
getShadowVerticalExtent(boxShadow(), top, bottom); }
> +    void getBoxShadowInlineDirectionExtent(int &logicalLeft, int
&logicalRight) { getShadowInlineDirectionExtent(boxShadow(), logicalLeft,
logicalRight); }

Here too.

> WebCore/rendering/style/RenderStyle.h:1278
> +    void getShadowExtent(const ShadowData*, int &top, int &right, int
&bottom, int &left) const;
> +    void getShadowHorizontalExtent(const ShadowData*, int &left, int &right)
const;
> +    void getShadowVerticalExtent(const ShadowData*, int &top, int &bottom)
const;
> +    void getShadowInlineDirectionExtent(const ShadowData* shadow, int
&logicalLeft, int &logicalRight) const
> +    {
> +	   return isHorizontalWritingMode() ? getShadowHorizontalExtent(shadow,
logicalLeft, logicalRight) : getShadowVerticalExtent(shadow, logicalLeft,
logicalRight);
> +    }

And here.