[webkit-reviews] review granted: [Bug 47359] Don't use the directory structure to gather tests for API tester : [Attachment 70109] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 47359: Don't use the directory structure to gather tests for API tester
https://bugs.webkit.org/show_bug.cgi?id=47359

Attachment 70109: Patch
https://bugs.webkit.org/attachment.cgi?id=70109&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70109&action=review

> WebKitTools/Scripts/run-api-tests:28
> +#   - Ability to run all tests in a suite.

Didn't you add this?

> WebKitTools/TestWebKitAPI/Test.h:45
> +	       TestsController::shared().registerCreateTestFunction(testSuite +
"/" + testCase, Register::create);

Perhaps the map key should contain both the suite and the test in a pair?