[webkit-reviews] review granted: [Bug 45271] HTML parser should provide script column position within HTML document to JavaScript engine : [Attachment 70071] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Peter Rybin
<peter.rybin at gmail.com>'s request for review:
Bug 45271: HTML parser should provide script column position within HTML
document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Attachment 70071: Patch
https://bugs.webkit.org/attachment.cgi?id=70071&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70071&action=review

This looks fantastic.  Thanks for the patch.  A couple very minor nits below.

> JavaScriptCore/wtf/text/TextPosition.h:32
> +

Extra line.

> JavaScriptCore/wtf/text/TextPosition.h:41
> + *

Extra line.

> JavaScriptCore/wtf/text/TextPosition.h:80
> +

extra line

> JavaScriptCore/wtf/text/TextPosition.h:141
> +

extra line

> WebCore/dom/XMLDocumentParserLibxml2.cpp:1392
> +    if (context) {

prefer early return.

> WebCore/dom/XMLDocumentParserLibxml2.cpp:1407
> +    if (context) {

prefer early return