[webkit-reviews] review granted: [Bug 47291] [Mac] [DRT] implement setSpatialNavigationEnabled : [Attachment 70082] patch v1

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 47291: [Mac] [DRT] implement setSpatialNavigationEnabled
https://bugs.webkit.org/show_bug.cgi?id=47291

Attachment 70082: patch v1
https://bugs.webkit.org/attachment.cgi?id=70082&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70082&action=review

> LayoutTests/platform/mac/Skipped:331
> +# Spatial Navigation: test can be affected by font metric differences.
>
+fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.ht
ml
>
+fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html


This is unfortunate. Can the tests be rewritten to avoid this?

> WebKitTools/DumpRenderTree/LayoutTestController.cpp:1222
> +    // Has mac implementation.

This comment seems redundant.