[webkit-reviews] review denied: [Bug 47275] Web Inspector: inspector settings/properties/states management should be extracted into separate class. : [Attachment 70079] [patch] initial version.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 47275: Web Inspector: inspector settings/properties/states management
should be extracted into separate class.
https://bugs.webkit.org/show_bug.cgi?id=47275

Attachment 70079: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=70079&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70079&action=review

> WebCore/inspector/InspectorController.cpp:123
> +const char* const InspectorController::LastActivePanel = "lastActivePanel";

Const names start with lower case.

> WebCore/inspector/InspectorState.h:18
> + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY

Should be Google :)

> WebCore/inspector/InspectorState.h:51
> +    virtual void saveToContainerAs(InspectorObject* container, const String&
name) const = 0;

Should be PassRefPtr<InspectorValue> toInspectorValue() and fromInspectorValue.


> WebCore/inspector/InspectorState.h:111
> +    INSPECTOR_PROPERTY(bool, monitoringXHR, setMonitoringXHR);

Could we please use a simple approach where we register and set properties
using classical OOP? (think chromium's PrefsService).

> WebCore/inspector/InspectorValues.h:174
> +    void set(const String& name, bool value) { setBoolean(name, value); }

set("foo", long_long) will result in setBoolean. I am not sure we are ready to
this. Should we use traits instead?

> WebKit/win/WebCoreSupport/WebInspectorClient.cpp:276
> +   
m_inspectedWebView->page()->inspectorController()->setInspectorStartsAttached(t
rue);

We should store this setting from within inspector controller.