[webkit-reviews] review requested: [Bug 45443] [GTK] Support for viewport meta tag : [Attachment 70074] Proposed Patch5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 06:20:59 PDT 2010


Joone Hur <joone at kldp.org> has asked  for review:
Bug 45443: [GTK] Support for viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=45443

Attachment 70074: Proposed Patch5
https://bugs.webkit.org/attachment.cgi?id=70074&action=review

------- Additional Comments from Joone Hur <joone at kldp.org>
- renamed WebKitViewportConfig to WebKitViewportAttributes.
- renamed viewport-config-changed signal to viewport-attributes-changed.
- not allowed to emit viewport-attributes-changed signal when
dispatchDidCommitLoad() was called.
- moved webkit_viewport_attributes_new() function declaration to
webkitprivate.h
- changed webkit_web_view_set_viewport_config() to
webkit_web_view_init_viewport_attributes


More information about the webkit-reviews mailing list