[webkit-reviews] review denied: [Bug 47336] [Qt] Update .def file for Symbian : [Attachment 70067] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Keith Kyzivat
<keith.kyzivat at nokia.com>'s request for review:
Bug 47336: [Qt] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=47336

Attachment 70067: Patch
https://bugs.webkit.org/attachment.cgi?id=70067&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70067&action=review

> WebKit/qt/symbian/eabi/QtWebKitu.def:821
> -	_ZNK8QWebPage28viewportConfigurationForSizeE5QSize @ 817 NONAME
> +	_ZN23DumpRenderTreeSupportQt20dumpHistoryCallbacksEb @ 817 NONAME
> +	_ZN23DumpRenderTreeSupportQt25dumpVisitedLinksCallbacksEb @ 818 NONAME
> +	_ZN23DumpRenderTreeSupportQt9plainTextERK8QVariant @ 819 NONAME
> +	_ZNK8QWebPage28viewportConfigurationForSizeERK5QSize @ 820 NONAME

I think instead of replacing 817 with dumpHistoryCallbacks and appending the
refreshed viewportConfigurationForSize overoad with ordinal 820, we should do
that we did in the qtwebkit-2.1 branch: update the viewportConfigurationForSize
signature for ordinal 817.