[webkit-reviews] review requested: [Bug 47167] [Qt] Webkit2 MacOS build fix : [Attachment 70070] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 05:46:08 PDT 2010


Luiz Agostini <luiz at webkit.org> has asked  for review:
Bug 47167: [Qt] Webkit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47167

Attachment 70070: patch
https://bugs.webkit.org/attachment.cgi?id=70070&action=review

------- Additional Comments from Luiz Agostini <luiz at webkit.org>
I rolled out last patch because it broke some builds. The problem was that
PLATFORM() macro may not be used in file WKNativeEvent.h.

Qt build is broken in MacOS because of the use of __APPLE__ macro in that file.
As it is a public file it is not easy conciliate the use of __APPLE__
and Qt when building Qt in MacOS. A solution is to have a Qt specific
WKNativeEvent.h that only has the typedef needed by Qt.


More information about the webkit-reviews mailing list