[webkit-reviews] review denied: [Bug 47249] [GTK] Fix the build for GTK+ 3 : [Attachment 70043] Another update for gdkdrawable deprecated api

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<carlosgc at gnome.org>'s request for review:
Bug 47249: [GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Attachment 70043: Another update for gdkdrawable deprecated api
https://bugs.webkit.org/attachment.cgi?id=70043&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70043&action=review

Looks good, but I have a couple suggestions.

> WebKit/gtk/ChangeLog:11
> +	   Some methods of GdkDrawable are deprecated in gtk2 and have been
> +	   remmoved in gtk3. Equivalent API has been added to GdkWindow.

Should be "removed." Might want to tighten up the ChangeLog text a little to
make it one continuous paragraph. It's good form to fill in the ChangeLog
method sections too.

> WebCore/platform/gtk/PlatformScreenGtk.cpp:70
> +#ifdef GTK_API_VERSION_2
>      return
gdk_drawable_get_visual(GDK_DRAWABLE(gtk_widget_get_window(container)));
> +#else
> +    return gdk_window_get_visual(gtk_widget_get_window(container));
> +#endif

I'd rather see gdk_window_get_visual defined in GtkVersioning.h, instead of
having the #ifdef here.