[webkit-reviews] review denied: [Bug 47114] Add ENABLE(ACCELERATED_2D_CANVAS) guard for m_uploadTexture : [Attachment 69683] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 23:45:11 PDT 2010


Andreas Kling <kling at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 47114: Add ENABLE(ACCELERATED_2D_CANVAS) guard for m_uploadTexture
https://bugs.webkit.org/show_bug.cgi?id=47114

Attachment 69683: Patch
https://bugs.webkit.org/attachment.cgi?id=69683&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69683&action=review

> WebCore/platform/graphics/skia/PlatformContextSkia.h:236
> +#if ENABLE(ACCELERATED_2D_CANVAS)
>      mutable RefPtr<Texture> m_uploadTexture;
> +#endif

There's an ENABLE(ACCELERATED_2D_CANVAS) guard just above, put both variables
in there instead.


More information about the webkit-reviews mailing list