[webkit-reviews] review denied: [Bug 47246] Improve ellipse path generation : [Attachment 69892] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Shane Stephens
<shanestephens at google.com>'s request for review:
Bug 47246: Improve ellipse path generation
https://bugs.webkit.org/show_bug.cgi?id=47246

Attachment 69892: Patch
https://bugs.webkit.org/attachment.cgi?id=69892&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69892&action=review

This doesn't change any pixel results? Also did you update to the latest DRT
updates on trunk? Something went wrong with applying the patch to the bots.

> WebCore/platform/graphics/Path.cpp:235
> +    static const unsigned step = 100;

Statics should be at the top, right after the header includes. please name it
something like gCircleFragments.

> WebCore/platform/graphics/Path.cpp:240
> +    float delta = 2.0 * piFloat / static_cast<float>(step);
> +    for (unsigned i = 1; i < step; i++) {

float delta = 2 * ....

++i instead of i++