[webkit-reviews] review denied: [Bug 47203] [Qt] No way to programatically specify element to focus the inspector : [Attachment 69855] Patch that adds inspect(QWebElement) method to QWebPage

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Eugene Ostroukhov
<eostroukhov at gmail.com>'s request for review:
Bug 47203: [Qt] No way to programatically specify element to focus the
inspector
https://bugs.webkit.org/show_bug.cgi?id=47203

Attachment 69855: Patch that adds inspect(QWebElement) method to QWebPage
https://bugs.webkit.org/attachment.cgi?id=69855&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69855&action=review

> WebKit/qt/Api/qwebpage.cpp:2278
>	       if (!d->hitTestResult.isNull()) {
> -		   d->getOrCreateInspector(); // Make sure the inspector is
created
> -		   d->inspector->show(); // The inspector is expected to be
shown on inspection
> -		  
d->page->inspectorController()->inspect(d->hitTestResult.d->innerNonSharedNode.
get());
> +		   inspect(d->hitTestResult.element());
>	       }

Coding style, the braces should be removed since only one statement remains
inside the if-block.

> WebKit/qt/Api/qwebpage.cpp:2303
> +    This function can be called to focus Web Inspector on specified element.
Web
> +    Inspector will become visible if it was not. Document element may be
passed.

English, would read better as:
This function focuses the inspector on the specified \a element.
The inspector becomes visible if it wasn't already.

> WebKit/qt/Api/qwebpage.cpp:2305
> +void QWebPage::inspect(const QWebElement& element) {

Coding style, { should be by itself on the next line.

> WebKit/qt/Api/qwebpage.cpp:2309
> +	d->getOrCreateInspector(); // Make sure the inspector is created
> +	d->inspector->show(); // The inspector is expected to be shown on
inspection
> +	d->page->inspectorController()->inspect(element.m_element);

Coding style, indents should be 4 spaces.

> WebKit/qt/Api/qwebpage.h:351
> +	void inspect(const QWebElement& element);

Coding style, indents should be 4 spaces.