[webkit-reviews] review denied: [Bug 46287] [Qt] Enable Netscape plugin metadata caching on Linux should not be set in QWebSettings::enablePersistentStorage : [Attachment 70024] Updated again as per Simon's suggstion.

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied David Leong
<david.leong at nokia.com>'s request for review:
Bug 46287: [Qt] Enable Netscape plugin metadata caching on Linux should not be
set in QWebSettings::enablePersistentStorage
https://bugs.webkit.org/show_bug.cgi?id=46287

Attachment 70024: Updated again as per Simon's suggstion.
https://bugs.webkit.org/attachment.cgi?id=70024&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70024&action=review

> WebKit/qt/ChangeLog:6
> +	   should not be set in QWebSettings::enablePersistentStorage.

What does this mean?

> WebKit/qt/ChangeLog:11
> +	   QWebSettings::enablePersistentStorage will now store the netscape
> +	   plugin cache to QDesktopServices::DataLocation.

This is incorrect, should be QDesktopServices::CacheLocation.

> WebKit/qt/Api/qwebsettings.cpp:1096
> +    // Path is not configurable and uses QDesktop services by default.

s/QDesktop services/QDesktopServices/