[webkit-reviews] review granted: [Bug 46769] Bundle should expose a reportException method : [Attachment 70023] Add InjectedBundle::reportException

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 21:11:29 PDT 2010


John Sullivan <sullivan at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 46769: Bundle should expose a reportException method
https://bugs.webkit.org/show_bug.cgi?id=46769

Attachment 70023: Add InjectedBundle::reportException
https://bugs.webkit.org/attachment.cgi?id=70023&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70023&action=review

> WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:232
> +    // Make sure the context has a DOMWindow global object, otherwise this
context didn't originate from a View.

I'm not sure if View with a capital V refers to a class or a named concept.
Maybe this comment could be improved.


More information about the webkit-reviews mailing list