[webkit-reviews] review granted: [Bug 45986] :first-letter should apply to "punctuation" after the first letter : [Attachment 70015] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 45986: :first-letter should apply to "punctuation" after the first letter
https://bugs.webkit.org/show_bug.cgi?id=45986

Attachment 70015: Patch
https://bugs.webkit.org/attachment.cgi?id=70015&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=70015&action=review

> WebCore/rendering/RenderBlock.cpp:5235
> +inline bool isPunctForFirstLetter(UChar c)

A “uation” here won’t hurt.

> WebCore/rendering/RenderBlock.cpp:5384
> +	   unsigned scanLength = length;
> +	   while (scanLength < oldText->length()) {

I’d write this as a for() loop and so scope scanLength.