[webkit-reviews] review denied: [Bug 47307] Remove support for ANGLE SH_VERSION <= 100 : [Attachment 69998] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 15:56:37 PDT 2010


Kenneth Russell <kbr at google.com> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 47307: Remove support for ANGLE SH_VERSION <= 100
https://bugs.webkit.org/show_bug.cgi?id=47307

Attachment 69998: proposed patch
https://bugs.webkit.org/attachment.cgi?id=69998&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
You will need to first roll forward the Chromium deps in WebKit (used to build
the DumpRenderTree tool, which depends on this code) to a version containing
the rolled-forward ANGLE. I suggest filing a separate bug for that and making
this one dependent on it. The file is WebKit/chromium/DEPS, chromium_rev. You
can verify that the roll-forward succeeds via "build-webkit --chromium
--debug". Mark this r? again once this is done.


More information about the webkit-reviews mailing list