[webkit-reviews] review granted: [Bug 47245] IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts. : [Attachment 69997] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 47245: IDBDatabase and IDBObjectStore metadata is not recovered correctly
when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245

Attachment 69997: Patch
https://bugs.webkit.org/attachment.cgi?id=69997&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69997&action=review

r=me

> WebCore/storage/IDBDatabase.cpp:62
> +    if (!objectStore || !m_setVersionTransaction)

Do this before you call the backend function!!

> WebCore/storage/IDBDatabaseBackendImpl.cpp:143
> +				     
createCallbackTask(&IDBDatabaseBackendImpl::removeObjectStoreFromMap, database,
objectStore)))

{}

> WebCore/storage/IDBDatabaseBackendImpl.cpp:217
> +				     
createCallbackTask(&IDBDatabaseBackendImpl::resetVersion, database,
m_version)))

use {}

> WebCore/storage/IDBObjectStoreBackendImpl.cpp:279
> +				     
createCallbackTask(&IDBObjectStoreBackendImpl::removeIndexFromMap, objectStore,
index)))

use {}s