[webkit-reviews] review granted: [Bug 47285] Remove the block-flow property and update writing-mode : [Attachment 69968] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 47285: Remove the block-flow property and update writing-mode
https://bugs.webkit.org/show_bug.cgi?id=47285

Attachment 69968: Patch
https://bugs.webkit.org/attachment.cgi?id=69968&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=69968&action=review

> WebCore/css/CSSProperty.cpp:45
> +static int resolveToPhysicalProperty(TextDirection direction, WritingMode
blockDirection, LogicalBoxSide logicalSide, const int* properties)

I’d rename the variable too.

> WebCore/css/CSSProperty.cpp:152
> +static int resolveToPhysicalProperty(WritingMode blockDirection,
LogicalExtent logicalSide, const int* properties)

Ditto.

> WebCore/css/CSSProperty.cpp:159
> +int CSSProperty::resolveDirectionAwareProperty(int propertyID, TextDirection
direction, WritingMode blockDirection)

Ditto.

> WebCore/css/CSSValueKeywords.in:762
> +# Standards values from CSS3

Standard?