[webkit-reviews] review denied: [Bug 47278] Add WebThemeEngine api for chromium/linux : [Attachment 69967] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Dave Moore <davemoore at google.com>'s
request for review:
Bug 47278: Add WebThemeEngine api for chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=47278

Attachment 69967: Patch
https://bugs.webkit.org/attachment.cgi?id=69967&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69967&action=review

> I can't remove the old WebThemeEngine.h without breaking the chromium build.
I'll do it once I've added support for the new api there, and changed its
includes.

Right, I just mean to remove it from the gyp file (I think that's harmless, it
just changes what file the IDE tries to open).	You can still change the
include in WebKit/chromium/src/ChromiumBridge.cpp, right?

r- for ChangeLog

> ChangeLog:1
> +2010-10-06  Dave Moore  <davemoore at chromium.org>

Actually, this is the wrong ChangeLog file.  You want to edit WebKit/ChangeLog
not the root ChangeLog.  I think if you're going to use webkit-patch, you need
to have a full WebKit checkout.  Alternately, you can probably use the svn
based scripts from your WebKit/WebKit/ directory (i.e., manually run
prepare-ChangeLog and svn-create-diff).