[webkit-reviews] review denied: [Bug 47002] Make resource identifiers unique across pages : [Attachment 69823] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 11:20:56 PDT 2010


Dmitry Titov <dimich at chromium.org> has denied Jenn Braithwaite
<jennb at chromium.org>'s request for review:
Bug 47002: Make resource identifiers unique across pages
https://bugs.webkit.org/show_bug.cgi?id=47002

Attachment 69823: patch
https://bugs.webkit.org/attachment.cgi?id=69823&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69823&action=review

Looks great, I understand the actual ASSERTS will come as a close next patch
since they rely on more code, so this adds a test ahead of code, which is ok.
r- since the test can be improved.

> LayoutTests/fast/frames/iframe-reparenting-id-collision.html:42
> +    w1.addEventListener("load", windowLoaded, false);

It could be more reliable to make this test to wait until both windows are
loaded, but at the same time to ensure that their inner iframes are still
loading.
It can be accomplished by making this test a http test and hitting the 'slow
loading' server script from iframes, while registering onload handler for both
windows. This will guarantee that the test is free from timing issues.


More information about the webkit-reviews mailing list