[webkit-reviews] review granted: [Bug 47280] [Qt] RunLoop implementation for WTR : [Attachment 69963] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 47280: [Qt] RunLoop implementation for WTR
https://bugs.webkit.org/show_bug.cgi?id=47280

Attachment 69963: Patch
https://bugs.webkit.org/attachment.cgi?id=69963&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69963&action=review

> WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:38
> +class RunUntilLoop : public QObject {

Run until what? a condition? RunSingle?

> WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:42
> +    static void start(bool& done)

ah seems to be a condition, I guess RunUntilConditionLoop would be a better
name.

> WebKitTools/WebKitTestRunner/qt/main.cpp:51
> +	   m_controller = new WTR::TestController(m_argc, const_cast<const
char**>(m_argv));

leaking m_controller?