[webkit-reviews] review granted: [Bug 46918] ContextShadow should not use the blur radius as kernel size of the box blurs : [Attachment 69942] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 6 10:15:02 PDT 2010
Dirk Schulze <krit at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 46918: ContextShadow should not use the blur radius as kernel size of the
box blurs
https://bugs.webkit.org/show_bug.cgi?id=46918
Attachment 69942: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=69942&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69942&action=review
LGTM. Please use a better phrasing in the ChangeLog.
> WebCore/ChangeLog:10
> + Calculate the size of the kernel in the blur algorihtm using the
> + radius instead of using directly. Change the name of the variables
using directly
something is missing here. What don't you want to use directly?
More information about the webkit-reviews
mailing list