[webkit-reviews] review granted: [Bug 47247] [Chromium] WebIDBKeyRange should handle null left/right pointers : [Attachment 69888] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 09:19:25 PDT 2010


Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 47247: [Chromium] WebIDBKeyRange should handle null left/right pointers
https://bugs.webkit.org/show_bug.cgi?id=47247

Attachment 69888: Patch
https://bugs.webkit.org/attachment.cgi?id=69888&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69888&action=review

> WebKit/chromium/src/WebIDBKeyRange.cpp:44
> +    if (left.type() == WebIDBKey::InvalidType && right.type() ==
WebIDBKey::InvalidType)

Will it ever be the case that only one of these is invalid?

LGTM otherwise.


More information about the webkit-reviews mailing list