[webkit-reviews] review granted: [Bug 47270] Move WebArchive serialization code into its own file : [Attachment 69947] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 09:13:35 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 47270: Move WebArchive serialization code into its own file
https://bugs.webkit.org/show_bug.cgi?id=47270

Attachment 69947: Patch v1
https://bugs.webkit.org/attachment.cgi?id=69947&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69947&action=review

> WebKitTools/ChangeLog:15
> +	   * DumpRenderTree/mac/DumpRenderTreeWebArchive.h: Added.
> +	   * DumpRenderTree/mac/DumpRenderTreeWebArchive.mm: Copied from
WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.

Maybe these should be called WebArchiveDumpSupport.h/mm? That would match
PixelDumpSupport, which we already have.


More information about the webkit-reviews mailing list