[webkit-reviews] review granted: [Bug 46738] Web Inspector: add event listener breakpoints sidebar pane : [Attachment 69778] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 46738: Web Inspector: add event listener breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=46738

Attachment 69778: Patch.
https://bugs.webkit.org/attachment.cgi?id=69778&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69778&action=review

> WebCore/inspector/front-end/BreakpointManager.js:150
> +	   breakpoint.compareTo = function(other)

We should introduce a dedicated class for XHR breakpoints and define the method
on it.

> WebCore/inspector/front-end/BreakpointManager.js:292
> +	       if (breakpointId)

it'd be harmless to do the assignment even if breakpointId is undefined.