[webkit-reviews] review denied: [Bug 46367] CSSParser: Enable rule selector source range extraction : [Attachment 69804] [PATCH] Rebase for compilability
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 6 05:42:16 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 46367: CSSParser: Enable rule selector source range extraction
https://bugs.webkit.org/show_bug.cgi?id=46367
Attachment 69804: [PATCH] Rebase for compilability
https://bugs.webkit.org/attachment.cgi?id=69804&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69804&action=review
Overall looks good. Few nits from me and we are ready to land.
> WebCore/css/CSSParser.cpp:-152
> - , m_currentStyleData(0)
Do not remove this line. You could access style data via rule data.
More information about the webkit-reviews
mailing list