[webkit-reviews] review granted: [Bug 47254] Only execute first SVG text layout phase if needed : [Attachment 69919] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 47254: Only execute first SVG text layout phase if needed
https://bugs.webkit.org/show_bug.cgi?id=47254

Attachment 69919: Patch
https://bugs.webkit.org/attachment.cgi?id=69919&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69919&action=review

Please look if the Renderer in ResourceGradient can't be const. Otherwise looks
good. r=me

> WebCore/ChangeLog:24
> +	   (WebCore::RenderSVGInline::objectBoundingBox): adapt to renames, use
RenderSVGText::locateRenderSVGTextAncestor().

s/adapt/Adapt/

> WebCore/rendering/RenderSVGResourceGradient.cpp:81
> -							      const
RenderObject* object)
> +							      RenderObject*
object)
>  {
> -    const RenderObject* textRootBlock =
SVGRenderSupport::findTextRootObject(object);
> +    RenderObject* textRootBlock =
RenderSVGText::locateRenderSVGTextAncestor(object);

Why not const RenderObject*?

> WebCore/rendering/RenderSVGResourceGradient.cpp:115
> -						const RenderObject* object,
> +						RenderObject* object,
>						GradientData* gradientData)
>  {
> -    const RenderObject* textRootBlock =
SVGRenderSupport::findTextRootObject(object);
> +    RenderObject* textRootBlock =
RenderSVGText::locateRenderSVGTextAncestor(object);

Ditto.