[webkit-reviews] review denied: [Bug 46918] ContextShadow should not use the blur radius as kernel size of the box blurs : [Attachment 69617] Proposed patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 46918: ContextShadow should not use the blur radius as kernel size of the
box blurs
https://bugs.webkit.org/show_bug.cgi?id=46918

Attachment 69617: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=69617&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69617&action=review

Please fix the issues and I'm fine with it. r- because of the issues.

> WebCore/platform/graphics/ContextShadow.cpp:88
> +    unsigned d = max(2.f, (2 / 3.f) * m_blurDistance);

d is unsigned, you can't use unsigned d = max(2.f
use
unsigned d = max<unsigned>(2, floorf(2 / 3.f * m_blurDistance)); instead.

> WebCore/platform/graphics/ContextShadow.cpp:158
> +    m_layerRect.inflate((m_type == BlurShadow) ? m_blurDistance : 0);

remove the braces arround m_type == BlurShadow

> WebCore/platform/graphics/ContextShadow.cpp:171
> +	       m_layerRect.inflate((m_type == BlurShadow) ? m_blurDistance :
0);

Ditto.