[webkit-reviews] review denied: [Bug 47181] SVGFEMergeNodeElement doesn't support dynamic invalidation : [Attachment 69921] Patch for feMergeNode properties

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Renata Hodovan
<reni at inf.u-szeged.hu>'s request for review:
Bug 47181: SVGFEMergeNodeElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=47181

Attachment 69921: Patch for feMergeNode properties
https://bugs.webkit.org/attachment.cgi?id=69921&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69921&action=review

Other than that it looks good...

> WebCore/svg/SVGFEMergeNodeElement.cpp:62
> +    if (attrName != SVGNames::inAttr)
> +	   return;
> +    if (Node* parentNode = parent()) {
> +	   RenderObject* renderer = parentNode->renderer();
> +	   if (renderer && renderer->isSVGResourceFilterPrimitive())
> +	      
RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);
> +    }
> +}

Sorry, for not being clear. I meant:

if (attrName != SVGNames::inAttr)
    return;

Node* parentNode = parent();
if (!parentNode)
    return;

RenderObject* renderer = parentNode->renderer();
if (!renderer || !renderer->isSVGResourceFilterPrimitive())
    return;

RenderSVGResource::mark...