[webkit-reviews] review denied: [Bug 47181] SVGFEMergeNodeElement doesn't support dynamic invalidation : [Attachment 69913] Patch for feMergeNode properties

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Renata Hodovan
<reni at inf.u-szeged.hu>'s request for review:
Bug 47181: SVGFEMergeNodeElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=47181

Attachment 69913: Patch for feMergeNode properties
https://bugs.webkit.org/attachment.cgi?id=69913&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69913&action=review

Looks good other than that, though as you can't commit yet on your own, you
probably need to upload a new patch, hence r-.

> WebCore/ChangeLog:8
> +	   Since feMergeNode doesn't have own renderer, we have to call the
invalidation via it's parent.

s/it's/its/

> WebCore/svg/SVGFEMergeNodeElement.cpp:55
> +    if (attrName == SVGNames::inAttr) {

If there's only one attribute to consider, you may want to use early exit style
here.
if (attrName != SVGNames::inAttr)
    return;