[webkit-reviews] review granted: [Bug 47044] Add FileSystemSync implementation for Worker : [Attachment 69901] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 47044: Add FileSystemSync implementation for Worker
https://bugs.webkit.org/show_bug.cgi?id=47044

Attachment 69901: Patch
https://bugs.webkit.org/attachment.cgi?id=69901&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69899&action=review

Just a few nits to address.

> WebCore/fileapi/DOMFileSystemBase.h:72
> +    bool getFile(const EntryBase* base, const String& path,
PassRefPtr<Flags>, PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);

remove "base"

> WebCore/fileapi/DOMFileSystemBase.h:73
> +    bool getDirectory(const EntryBase* base, const String& path,
PassRefPtr<Flags>, PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);

remove "base"

> WebCore/fileapi/FileEntry.h:-42
> -class DOMFileSystem;

Please consider adding this back but as Base.