[webkit-reviews] review granted: [Bug 47234] [BREWMP] Translate key code in PlatformKeyboardEvent with IKeysMapping : [Attachment 69871] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kim, kyusun
<maniagoon at company100.net>'s request for review:
Bug 47234: [BREWMP] Translate key code in PlatformKeyboardEvent with
IKeysMapping
https://bugs.webkit.org/show_bug.cgi?id=47234

Attachment 69871: Patch
https://bugs.webkit.org/attachment.cgi?id=69871&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69871&action=review

> WebCore/platform/brew/PlatformKeyboardEventBrew.cpp:160
> +    if ((m_type == Char) && modifiers) {

nit: Checking "m_type" and checking "type" are mixed in the constructor.  It's
confusing.