[webkit-reviews] review granted: [Bug 47230] Avoid inlining large and/or virtual functions in widely included header files : [Attachment 69869] applies to ToT

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 47230: Avoid inlining large and/or virtual functions in widely included
header files
https://bugs.webkit.org/show_bug.cgi?id=47230

Attachment 69869: applies to ToT
https://bugs.webkit.org/attachment.cgi?id=69869&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69869&action=review

<3

> WebCore/dom/QualifiedName.h:63
> -    ~QualifiedName() { deref(); }
> +    ~QualifiedName();

You sure there's no perf hit from making this non-inline?

> WebCore/platform/network/HTTPHeaderMap.cpp:80
> +

Extra blank lines?