[webkit-reviews] review denied: [Bug 47030] Clean up resources when LayerRenderer changes : [Attachment 69545] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 5 14:50:22 PDT 2010


James Robinson <jamesr at chromium.org> has denied Victoria Kirst
<vrk at google.com>'s request for review:
Bug 47030: Clean up resources when LayerRenderer changes
https://bugs.webkit.org/show_bug.cgi?id=47030

Attachment 69545: Patch
https://bugs.webkit.org/attachment.cgi?id=69545&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
This is copy-paste from ContentLayerChromium so we should move this logic up to
the base class.  Specifically, add a virtual cleanupResources() function to
LayerChromium and have LayerChromium::setLayerRenderer() invoke it.


More information about the webkit-reviews mailing list