[webkit-reviews] review denied: [Bug 46893] The parenthetical assertion checking isn't working in some cases with YARR Interpreter : [Attachment 69345] proposed patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Peter Varga
<pvarga at inf.u-szeged.hu>'s request for review:
Bug 46893: The parenthetical assertion checking isn't working in some cases
with YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46893

Attachment 69345: proposed patch
https://bugs.webkit.org/attachment.cgi?id=69345&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=69345&action=review

I know it's only a small thing, but I'll r-, since I don't like the unnecessary
*-1.  Otherwise, looks great!

> JavaScriptCore/yarr/RegexInterpreter.cpp:1599
> +		       int positiveInputOffset = -1 * (term.inputPosition -
currentCountAlreadyChecked);

I think this could be a little more clear as:
+    ASSERT(currentCountAlreadyChecked > term.inputPosition);
+    int positiveInputOffset = currentCountAlreadyChecked - term.inputPosition;