[webkit-reviews] review denied: [Bug 47059] [Qt] Handle multipart images : [Attachment 69826] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 47059: [Qt] Handle multipart images
https://bugs.webkit.org/show_bug.cgi?id=47059

Attachment 69826: Patch
https://bugs.webkit.org/attachment.cgi?id=69826&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69826&action=review

Quick r- for somewhat superficial reasons.

Peter Hartmann (p--hartmann on IRC) has been working on multipart support for
QNAM, I've asked him to have a look at this.

> WebCore/platform/network/qt/QNetworkReplyHandler.cpp:432
> +    int s = contentType.lastIndexOf("boundary=") + 9;

"s" is not a good variable name.

> WebCore/platform/network/qt/QNetworkReplyHandler.cpp:446
> +	   int bs = data->indexOf(boundary);

"bs" is not a good variable name.

> WebCore/platform/network/qt/QNetworkReplyHandler.h:72
> +    void removeMultipartHeaders(QByteArray* data);
> +    void processMultipartResponse(QByteArray* data, ResourceHandleClient*
client);

None of the argument names (data, data and client) are needed here.

> WebCore/platform/network/qt/QNetworkReplyHandler.h:73
> +    bool isMultipartResponse();

This method should be const.