[webkit-reviews] review granted: [Bug 46493] [chromium] Add mipmap support for ImageLayerChromium : [Attachment 69637] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 5 13:14:29 PDT 2010
James Robinson <jamesr at chromium.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 46493: [chromium] Add mipmap support for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=46493
Attachment 69637: Patch
https://bugs.webkit.org/attachment.cgi?id=69637&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69637&action=review
Looks good
> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:272
> + bool generateMipmap = (requestMipmap == useMipmap)
> + &&
(layerRenderer()->contentLayerSharedValues()->npotSupported()
> + || (isPowerOfTwo(updateRect.width()) &&
isPowerOfTwo(updateRect.height())));
nit: the indentation is a little odd here. Maybe indent the || line a bit more
so it's clearer?
More information about the webkit-reviews
mailing list