[webkit-reviews] review granted: [Bug 33299] [Gtk] FreeType backend does not respect FC_MATRIX property : [Attachment 68273] Patch for this issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 5 10:04:37 PDT 2010


chris fleizach <cfleizach at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 33299: [Gtk] FreeType backend does not respect FC_MATRIX property
https://bugs.webkit.org/show_bug.cgi?id=33299

Attachment 68273: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=68273&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68273&action=review

r=me, but you should address the "new SimpleFontData" thing, even though its
existing code

> WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp:89
>  

shouldn't this be adoptRef or something. Naked news are no longer in favor i
believe.


More information about the webkit-reviews mailing list