[webkit-reviews] review denied: [Bug 47181] SVGFEMergeNodeElement doesn't support dynamic invalidation : [Attachment 69792] Patch for feMergeNode properties

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Renata Hodovan
<reni at inf.u-szeged.hu>'s request for review:
Bug 47181: SVGFEMergeNodeElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=47181

Attachment 69792: Patch for feMergeNode properties
https://bugs.webkit.org/attachment.cgi?id=69792&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Not sure, why you need feComposite on the tests. A test like this should be as
simple as possible :-) Nevertheless, the patch itself looks great, but you
should describe in the ChangeLog what you did to fix this issue. For example
why did you ask the parent? why doesn't feMergeNode have a renderer, so that
you have to call invalidation via the parent? And so on. As long as you don't
have commit privileges, you have to upload a second patch. :-( r- because of
the ChangeLog.