[webkit-reviews] review denied: [Bug 46943] [chromium] getData('text/uri-list') should return the same thing that was passed to setData('text/uri-list') : [Attachment 69763] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 46943: [chromium] getData('text/uri-list') should return the same thing
that was passed to setData('text/uri-list')
https://bugs.webkit.org/show_bug.cgi?id=46943

Attachment 69763: Patch
https://bugs.webkit.org/attachment.cgi?id=69763&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=69763&action=review

>
LayoutTests/editing/pasteboard/script-tests/dataTransfer-setData-getData.js:119

> +    test("text/uri-list", "# comment\r\n# comment 2\r\n# comment 3", 
> +	    "URL", null);

The spec says this should return an empty string, not null:
http://dev.w3.org/html5/spec/dnd.html
"If there is no data with that format, or if there is but it has no URLs, then
the method must return the empty string."

> WebCore/platform/chromium/ChromiumDataObject.cpp:145
>	   success = !m_url.isEmpty();
>	   return m_url.string();

Maybe the fix is as simple as
  success = !m_url.isEmpty() || !m_uriList.isEmpty();
?